Skip to content

Add a timeout in wait_for_dump_creation #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2020
Merged

Add a timeout in wait_for_dump_creation #168

merged 2 commits into from
Nov 17, 2020

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Nov 10, 2020 •
edited
Loading

Currently, the wait_for_dump_creation could lead to an infinite loop.

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Nov 10, 2020
@curquiza curquiza requested a review from eskombro November 10, 2020 11:09
eskombro
eskombro approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@eskombro eskombro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@curquiza
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 17, 2020

Build succeeded:

@bors bors bot merged commit 251fb27 into master Nov 17, 2020
@bors bors bot deleted the fix-dumps-util branch November 17, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskombro eskombro eskombro approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curquiza @eskombro