Skip to content

Adding Python 3.10 to CI tests #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 4, 2021
Merged

Adding Python 3.10 to CI tests #303

merged 2 commits into from
Aug 4, 2021

Conversation

sanders41
Copy link
Collaborator

Relates to #301

@sanders41
Copy link
Collaborator Author

sanders41 commented Aug 4, 2021 •
edited
Loading

I think this is failing the 3.10 install because the installer is using actions/setup-python@v1 instead of actions/setup-python@v2. It is the only difference I see here and some other repos where I have it setup. If you want to stick with v1 I can just close this, or I could try upgrading to v2 if you like. Unfortunately there is no way to test Actions locally so the only way to know for sure is to try it.

@alallema
Copy link
Contributor

alallema commented Aug 4, 2021

Let's try the actions/setup-python@v2 😃

@sanders41
Copy link
Collaborator Author

@alallema bumping the installer version fixed the issue.

alallema
alallema approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks, @sanders41

@alallema
Copy link
Contributor

alallema commented Aug 4, 2021

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 4, 2021

Build succeeded:

@bors bors bot merged commit e8357a4 into main Aug 4, 2021
@bors bors bot deleted the py310 branch August 4, 2021 12:47
@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanders41 @alallema @curquiza