-
Notifications
You must be signed in to change notification settings - Fork 90
Changes related to the next MeiliSearch release (v0.22.0) #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2917d07
Update README.md
meili-bot a4bd4f4
Update default ranking rules
alallema 963e1ea
Add sortable-attributes
alallema c6a2ea8
Add tests
alallema 74c6cc6
Update code_samples
alallema 85c0703
Update .code-samples.meilisearch.yaml
alallema d0f4a5a
Fix test for more relevancy on sort
alallema ff66e91
Merge branch 'main' into bump-meilisearch-v0.22.0
alallema 4498356
Apply modification from code review
alallema File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,7 @@ | |
'typo', | ||
'proximity', | ||
'attribute', | ||
'sort', | ||
'exactness' | ||
] | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ | |
'typo', | ||
'proximity', | ||
'attribute', | ||
'sort', | ||
'exactness' | ||
] | ||
|
||
|
57 changes: 57 additions & 0 deletions
57
meilisearch/tests/settings/test_settings_sortable_attributes_meilisearch.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
# pylint: disable=invalid-name | ||
|
||
SORTABLE_ATTRIBUTES = ['title', 'release_date'] | ||
|
||
def test_get_sortable_attributes(empty_index): | ||
"""Tests getting the sortable attributes.""" | ||
response = empty_index().get_sortable_attributes() | ||
assert isinstance(response, list) | ||
assert response == [] | ||
|
||
def test_update_sortable_attributes(empty_index): | ||
"""Tests updating the sortable attributes.""" | ||
index = empty_index() | ||
response = index.update_sortable_attributes(SORTABLE_ATTRIBUTES) | ||
index.wait_for_pending_update(response['updateId']) | ||
get_attributes = index.get_sortable_attributes() | ||
assert len(get_attributes) == len(SORTABLE_ATTRIBUTES) | ||
for attribute in SORTABLE_ATTRIBUTES: | ||
assert attribute in get_attributes | ||
|
||
def test_update_sortable_attributes_to_none(empty_index): | ||
"""Tests updating the sortable attributes at null.""" | ||
index = empty_index() | ||
# Update the settings first | ||
response = index.update_sortable_attributes(SORTABLE_ATTRIBUTES) | ||
update = index.wait_for_pending_update(response['updateId']) | ||
assert update['status'] == 'processed' | ||
# Check the settings have been correctly updated | ||
get_attributes = index.get_sortable_attributes() | ||
for attribute in SORTABLE_ATTRIBUTES: | ||
assert attribute in get_attributes | ||
# Launch test to update at null the setting | ||
response = index.update_sortable_attributes(None) | ||
index.wait_for_pending_update(response['updateId']) | ||
response = index.get_sortable_attributes() | ||
assert response == [] | ||
|
||
def test_reset_sortable_attributes(empty_index): | ||
"""Tests resetting the sortable attributes setting to its default value""" | ||
index = empty_index() | ||
# Update the settings first | ||
response = index.update_sortable_attributes(SORTABLE_ATTRIBUTES) | ||
update = index.wait_for_pending_update(response['updateId']) | ||
assert update['status'] == 'processed' | ||
# Check the settings have been correctly updated | ||
get_attributes = index.get_sortable_attributes() | ||
assert len(get_attributes) == len(SORTABLE_ATTRIBUTES) | ||
for attribute in SORTABLE_ATTRIBUTES: | ||
assert attribute in get_attributes | ||
# Check the reset of the settings | ||
response = index.reset_sortable_attributes() | ||
assert isinstance(response, dict) | ||
assert 'updateId' in response | ||
index.wait_for_pending_update(response['updateId']) | ||
response = index.get_sortable_attributes() | ||
assert isinstance(response, list) | ||
assert response == [] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.