Windows OS encoding issue #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
changed the title
alallema
added
the
skip-changelog
alallema
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Thanks for this PR @jrinder42 and for raising the associate issue!
LGTM! 🎉
Thank you for contributing to MeiliSearch. If you are participating in Hacktoberfest, and you would like to receive a small gift from MeiliSearch too, please complete this form.
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR
Bug fix - Issue #342
Description
Explicitly add the encoding type when creating the long description in the setup.py script, otherwise running tox throws an error in Windows