Skip to content

Addition related to API keys #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 30, 2021
Merged

Addition related to API keys #382

merged 5 commits into from
Dec 30, 2021

Conversation

alallema
Copy link
Contributor

@alallema alallema commented Dec 29, 2021

Breaking Changes

Granular management of API keys is now added to MeiliSearch. New methods have been created to manage this:

  • http.patch use by update_key
  • client.get_key get information about a specific API key.
  • client.create_key create a new API key.
  • client.delete_key delete an API key.
  • client.update_key update an API key.

Note: Thanks to @sanders41 whose code is largely inspired by his implementation and here.

@alallema alallema marked this pull request as ready for review December 29, 2021 14:17
@alallema alallema requested a review from bidoubiwa December 29, 2021 14:20
Copy link
Collaborator

@sanders41 sanders41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alallema
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Dec 30, 2021
382: Addition related to API keys r=alallema a=alallema

### Breaking Changes

Granular management of API keys is now added to MeiliSearch. New methods have been created to manage this:
- `http.patch` use by `update_key`
- `client.get_key` get information about a specific API key.
- `client.create_key` create a new API key.
- `client.delete_key` delete an API key.
- `client.update_key` update an API key.

Note: Thanks to `@sanders41` whose code is largely inspired by [his implementation](https://github.com/sanders41/meilisearch-python-async/blob/e44941b7bf5735c8e99f0a2a12b707db03ac048a/meilisearch_python_async/client.py#L298) and [here](#372 (comment)).

Co-authored-by: alallema <[email protected]>
@bors
Copy link
Contributor

bors bot commented Dec 30, 2021

Build failed:

@alallema alallema merged commit ba9ae2e into bump-meilisearch-v0.25.0 Dec 30, 2021
@alallema alallema deleted the keys branch December 30, 2021 15:30
@alallema alallema added the breaking-change The related changes are breaking for the users label Jan 11, 2022
bors bot added a commit that referenced this pull request Jan 12, 2022
370: Changes related to the next MeiliSearch release (v0.25.0) r=alallema a=meili-bot

Related to this issue: meilisearch/integration-guides#157

This PR:
- gathers the changes related to the next MeiliSearch release (v0.25.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases).
- might eventually contain test failures until the MeiliSearch v0.25.0 is out.

⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.25.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._

Done:
- #371 
- #381 
- #372 
- #382 
- #396 

Co-authored-by: meili-bot <[email protected]>
Co-authored-by: alallema <[email protected]>
Co-authored-by: Amélie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants