Skip to content

Add redundant export to fix import error #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Add redundant export to fix import error #384

merged 2 commits into from
Jan 3, 2022

Conversation

sanders41
Copy link
Collaborator

What does this PR do?

Fixes #383

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to MeiliSearch!

@sanders41
Copy link
Collaborator Author

Interesting...it looks like pyright and pylint disagree with each other on this so I disabled the pylint error. The other option is to leave things as they are now, close this PR, and let pyright show users an error.

@alallema alallema added the skip-changelog The PR will not appear in the release changelogs label Jan 3, 2022
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sanders41 for this fix!

@alallema
Copy link
Contributor

alallema commented Jan 3, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 3, 2022

@bors bors bot merged commit fcb5e86 into main Jan 3, 2022
@bors bors bot deleted the re-export branch January 3, 2022 08:22
@alallema alallema added bug Something isn't working and removed skip-changelog The PR will not appear in the release changelogs labels Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pyright Client is not exported error
2 participants