Skip to content

Add type attribute to error handler #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2022
Merged

Add type attribute to error handler #388

merged 2 commits into from
Jan 10, 2022

Conversation

voloyev
Copy link

@voloyev voloyev commented Jan 6, 2022

What does this PR do?

Fixes #354

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to MeiliSearch!

alallema
alallema approved these changes Jan 10, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, for this PR @voloyev.
LGMT! 🎉

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 10, 2022

Build succeeded:

@bors bors bot merged commit 970da7a into meilisearch:main Jan 10, 2022
@alallema alallema added the enhancement New feature or request label Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add type to error handler
2 participants
@voloyev @alallema