Improve Docker configuration in the package #467
Conversation
alallema
force-pushed
the
meili-bot/docker
branch
from
334f825 to
1311868
Compare
alallema
force-pushed
the
meili-bot/docker
branch
from
1311868 to
5c65a89
Compare
alallema
force-pushed
the
meili-bot/docker
branch
from
56b9641 to
0fc512e
Compare
alallema
force-pushed
the
meili-bot/docker
branch
from
0fc512e to
9a39ed0
Compare
Co-authored-by: Bruno Casali <[email protected]>
CONTRIBUTING.md
Outdated
|
|
||
| Example of running all the checks with docker: | ||
| ```bash | ||
| docker-compose run --rm package |
There was a problem hiding this comment.
You must add the entire command here, to make it possible to people override your default command CMD in the python Dockerfile.
There was a problem hiding this comment.
I know but I find this way more clean and the user can modify the Dockerfile in case
There was a problem hiding this comment.
@brunoocasali the advantage of having a Dockerfile is just to run a command like docker-compose up
I think the user will have no problem finding the command to modify it! And the test in python is really quick so I think is a win-win even if it launches all the verification. I'm not sure a lot of users will use it and let alone do only part of the tests.
This way is ready to use! 😃
Don't you think?
There was a problem hiding this comment.
It seems strange to me to use the docker-compose up to run a short-lived command.
My point about adding the entire command in the CONTRIBUTING is that we agreed to provide that command in every other repo 😄
There was a problem hiding this comment.
@brunoocasali it's the same command docker-compose run --rm package I just remove the specific command line
|
bors merge |
This PR is auto-generated.
Add a basic Docker configuration based on this integration-guides issue.