Skip to content

Fix typing of Index.get_documents #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

Fix typing of Index.get_documents #501

merged 1 commit into from
Jul 20, 2022

Conversation

sapristi
Copy link
Contributor

@sapristi sapristi commented Jul 19, 2022 •
edited
Loading

Pull Request

What does this PR do?

Fix typing of Index.get_documents

Fixes #500

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sapristi sapristi changed the title Update typing of get_documents Fix typing of Index.get_documents Jul 19, 2022
alallema
alallema approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sapristi for this PR and for contributing to Meilisearch ❤️
LGTM! ✨

@alallema
Copy link
Contributor

bors merge

@alallema alallema added maintenance Anything related to maintenance (CI, tests, refactoring...) bug Something isn't working labels Jul 20, 2022
@bors
Copy link
Contributor

bors bot commented Jul 20, 2022

Build succeeded:

@bors bors bot merged commit e57285f into meilisearch:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
bug Something isn't working maintenance Anything related to maintenance (CI, tests, refactoring...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing of Index.get_documents has not been updated
2 participants
@sapristi @alallema