Skip to content

Add pipenv install in the CONTRIBUTING guide #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Conversation

brunoocasali
Copy link
Member

@brunoocasali brunoocasali commented Sep 2, 2022

If we don't add this command, it does not work :)

image

@sanders41
Copy link
Collaborator

@brunoocasali I have never seen this error with camel_converter before. It does have types included with it. If you still see that message after merging #516 will you report it here https://github.com/sanders41/camel-converter/issues and I will look into it?

@brunoocasali
Copy link
Member Author

@brunoocasali I have never seen this error with camel_converter before. It does have types included with it. If you still see that message after merging #516 will you report it here https://github.com/sanders41/camel-converter/issues and I will look into it?

Hi @sanders41!

I think this was caused just because my environment was not up to date. After running pipenv install --dev works fine :)

@brunoocasali brunoocasali added the documentation Improvements or additions to documentation label Sep 2, 2022
@sanders41
Copy link
Collaborator

OK good...I was trying to think of what it could be 😄

Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @brunoocasali for this PR!
Good catch, LGTM 🔥

@alallema
Copy link
Contributor

alallema commented Sep 5, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 5, 2022

@bors bors bot merged commit f48fc23 into main Sep 5, 2022
@bors bors bot deleted the brunoocasali-patch-1 branch September 5, 2022 08:55
bors bot added a commit that referenced this pull request Sep 21, 2022
533: Update version for the next release (v0.20.0) r=brunoocasali a=alallema

Update to the next version

**Note:**
This release is a replacement for the v0.19.2 which should be a minor update instead of a patch update.
https://github.com/meilisearch/meilisearch-python/releases/tag/v0.19.2

## 💥 Breaking changes
* API resource output as class to utilize dot notation for attributes (#513) `@ElamC`
    * `Document`, `Index` and `Task` are now class and the attributes of these classes are now accessible via dot notation:
    * `document.offset`, `document.limit`, `document.total`
    * `task.uid`, `task.duration`, `task.status` ...
* Add pipenv install in the CONTRIBUTING guide (#519) `@brunoocasali`
* Bump mako from 1.2.1 to 1.2.2 due to security issue (#528) 

Thanks again to `@ElamC,` `@alallema,` `@brunoocasali!` 🎉


Co-authored-by: alallema <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants