Add camel_converter to package dependencies #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
added
bug
|
bors merge |
sanders41
reviewed
Sep 21, 2022
| @@ -6,7 +6,8 @@ | |||
|
|
|||
| setup( | |||
| install_requires=[ | |||
| "requests" | |||
| "requests", | |||
| "camel_converter" | |||
There was a problem hiding this comment.
I believe pypi will understand this and convert it but the package name is camel-converter on pypi so if there are still issues that is probably it.
There was a problem hiding this comment.
Do you think we should release again with camel-converter instead?
There was a problem hiding this comment.
I tested pip install camel_converter and pypi did understand and install correctly so I think it is fine.
There was a problem hiding this comment.
I tested and it did install, but there is still an issue:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/paul/t/.venv/lib/python3.10/site-packages/meilisearch/__init__.py", line 1, in <module>
from meilisearch.client import Client as Client # pylint: disable=useless-import-alias
File "/home/paul/t/.venv/lib/python3.10/site-packages/meilisearch/client.py", line 9, in <module>
from meilisearch.index import Index
File "/home/paul/t/.venv/lib/python3.10/site-packages/meilisearch/index.py", line 11, in <module>
from meilisearch.models.task import Task, TaskInfo, TaskResults
File "/home/paul/t/.venv/lib/python3.10/site-packages/meilisearch/models/task.py", line 2, in <module>
from camel_converter.pydantic_base import CamelBase
File "/home/paul/t/.venv/lib/python3.10/site-packages/camel_converter/pydantic_base.py", line 4, in <module>
raise ImportError("camel-converter must be installed with the pydantic extra to use this class")
ImportError: camel-converter must be installed with the pydantic extra to use this classIt needs to be camel-converter[pydantic] to include the extras
There was a problem hiding this comment.
Thank you @sanders41 I will try to fix it today!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #532