Skip to content

chores: replace MEILISEARCH_HOST with MEILISEARCH_URL #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2022
Merged

chores: replace MEILISEARCH_HOST with MEILISEARCH_URL #557

merged 2 commits into from
Oct 12, 2022

Conversation

dibashthapa
Copy link
Contributor

Pull Request

Related issue

Fixes #555

What does this PR do?

  • replaces MEILISEARCH_HOST by MEILISEARCH_URL as mentioned in the issue

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

alallema
alallema previously approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dibashthapa for this PR!
LGTM! I have added a modification suggested by @sanders41 on this PR #556 the same issue.
Thanks again for contributing with Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some swag from Meilisearch too, please complete this form.

@alallema
Copy link
Contributor

bors merge

@alallema alallema mentioned this pull request Oct 12, 2022
Closed
3 tasks
@bors
Copy link
Contributor

bors bot commented Oct 12, 2022

Build succeeded:

@bors bors bot merged commit a9fcdd9 into meilisearch:main Oct 12, 2022
@alallema
Copy link
Contributor

This message is sent automatically

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

@alallema alallema added the skip-changelog The PR will not appear in the release changelogs label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace MEILISEARCH_HOST by MEILISEARCH_URL in the docker config
2 participants
@dibashthapa @alallema