Skip to content

Add support for python 3.11 #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 26, 2022
Merged

Add support for python 3.11 #578

merged 4 commits into from
Oct 26, 2022

Conversation

sanders41
Copy link
Collaborator

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • Python 3.11 was released yesterday. This PR adds 3.11 to the tests and adds 3.11 to the supported versions.
  • Bumped pytest from 7.1.3 to 7.2.0 to fix a compatibility issue with Python 3.11

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

alallema
alallema previously approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sanders41 for this PR and your reactivity 🚀
LGTM! 🔥

Note: I add Tests / integration-tests (3.11) to Branches protection rules

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 26, 2022

Configuration problem:
bors.toml: syntax error

alallema
alallema approved these changes Oct 26, 2022
View reviewed changes
bors.toml Outdated
Comment on lines 7 to 8
'integration-tests (3.10)'
'integration-tests (3.11)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'integration-tests (3.10)'
'integration-tests (3.11)',
'integration-tests (3.10)',
'integration-tests (3.11)'

Sorry I miss that

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Oct 26, 2022

Build succeeded:

@bors bors bot merged commit ccf7e19 into main Oct 26, 2022
@bors bors bot deleted the python311 branch October 26, 2022 13:58
@alallema
Copy link
Contributor

This message is sent automatically

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.

@alallema alallema added dependencies Pull requests that update a dependency file skip-changelog The PR will not appear in the release changelogs enhancement New feature or request and removed skip-changelog The PR will not appear in the release changelogs labels Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanders41 @alallema