Add delete task api for v0.30.0 #598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alallema
force-pushed
the
bump-meilisearch-v0.30.0
branch
from
dee4333 to
c54dbf0
Compare
alallema
force-pushed
the
add_delete_task_api_for_v0.30.0
branch
from
727e71f to
463ea19
Compare
brunoocasali
approved these changes
Nov 28, 2022
| @@ -463,6 +463,25 @@ def cancel_tasks(self, parameters: dict[str, Any]) -> TaskInfo: | |||
| """ | |||
| return cancel_tasks(self.config, parameters=parameters) | |||
|
|
|||
| def delete_tasks(self, parameters: dict[str, Any]) -> TaskInfo: | |||
There was a problem hiding this comment.
Using types in dynamic languages is complex, but I believe we at least can allow or not some parameters. WDYT?
I have to do that on the ruby side because of the camelCase/snake_case conversion, but it could be an excellent addition to the python SDK... (a issue could be created in this case)
There was a problem hiding this comment.
Oh, great idea it could be a really nice addition but I don't know how to do that in python, to be honest.
I will check it and create an issue about it.
bors bot
added a commit
that referenced
this pull request
Nov 28, 2022
588: Changes related to the next Meilisearch release (v0.30.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#221 This PR: - gathers the changes related to the next Meilisearch release (v0.30.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v0.30.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.30.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ - #597 - #595 - #596 - #598 - #603 Co-authored-by: meili-bot <[email protected]> Co-authored-by: alallema <[email protected]> Co-authored-by: Amélie <[email protected]>
bors bot
added a commit
that referenced
this pull request
Nov 28, 2022
588: Changes related to the next Meilisearch release (v0.30.0) r=alallema a=meili-bot Related to this issue: meilisearch/integration-guides#221 This PR: - gathers the changes related to the next Meilisearch release (v0.30.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v0.30.0 is out.⚠️ This PR should NOT be merged until the next release of Meilisearch (v0.30.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ - #597 - #595 - #596 - #598 - #603 Co-authored-by: meili-bot <[email protected]> Co-authored-by: alallema <[email protected]> Co-authored-by: Amélie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the delete task API see spec
Enhancement
It is now possible to delete your tasks:
example:
TODO
deletel_tasks()uid