Specify dependencies for python < 3.11 #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanders41
added
the
skip-changelog
alallema
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
Thank you @sanders41 for this PR!
So happy it seems to fix the issue, indeed 🚀
|
bors merge |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
I did some testing and think this will solve the issue with dependabot. I created the
Pipfile.lockwith python 3.11 then tested with the supported python versions < 3.11 and this removed the errors. I can't be sure how dependabot is doing it so there is a chance there could still be errors, but it seems like this will work.What does this PR do?
Pipfileto specify needed dependencies for python < 3.11. These dependencies seem to only be needed bypytestor pylint` so I made them dev dependencies.PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!