Skip to content

Bump isort from 5.11.4 to 5.12.0 #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Bump isort from 5.11.4 to 5.12.0 #667

wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 30, 2023 •
edited
Loading

Bumps isort from 5.11.4 to 5.12.0.

Release notes

Sourced from isort's releases.

5.12.0

Changes

Changelog

Sourced from isort's changelog.

5.12.0 January 28 2023

  • Removed support for Python 3.7
  • Fixed incompatiblity with latest poetry version
  • Added support for directory limitations within built in git hook
Commits
  • e44834b Fix changelog / version to a minor bump due to the size of the change
  • 82569d9 Bump version to 5.11.5
  • e00db96 Formatting fix
  • e833931 Merge pull request #2078 from jooola/fix_poetry_validation
  • 0d219a6 fix: poetry pip-shims extras dependency
  • ae0cc1c Merge pull request #1967 from vkomarov-r7/feature/directory-hooks
  • 06d8ef5 Merge pull request #1948 from timgates42/bugfix_typo_determination
  • 0c8a8b8 Merge pull request #2076 from marksmayo/main
  • 5b63fba Clean up
  • a0cb1b8 Fix tmuxp test
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
> **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file skip-changelog The PR will not appear in the release changelogs labels Jan 30, 2023
@dependabot dependabot bot force-pushed the dependabot/pip/isort-5.12.0 branch from 8ce54e0 to bc7e807 Compare January 31, 2023 04:04
@alallema
Copy link
Contributor

alallema commented Feb 2, 2023

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/pip/isort-5.12.0 branch from bc7e807 to 41b8f7e Compare February 2, 2023 12:01
@sanders41 sanders41 mentioned this pull request Feb 4, 2023
Merged
3 tasks
bors bot added a commit that referenced this pull request Feb 4, 2023
@bors @sanders41
Merge #674
5f0942b 
674: Fix pylint and isort errors r=alallema a=sanders41

# Pull Request

## Related issue
N/A

## What does this PR do?
- Fixes the pylint errors in #672
- Fixes isort upgrade errors in #667
- Causes headaches from fighting with pipenv again 😄 

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Paul Sanders <[email protected]>
@alallema
Copy link
Contributor

alallema commented Feb 4, 2023

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/pip/isort-5.12.0 branch from 41b8f7e to 92e34c8 Compare February 4, 2023 22:21
@sanders41
Copy link
Collaborator

Looks like isort removed support for python 3.7 in 5.12.0

From the release notes: Removal Python 3.7 (https://github.com/PyCQA/isort/pull/2064) @staticdev

There are a few options here:

  • hold back the isort version
  • only install isort for python > 3.7. This would only affect development and I doubt anyone is using 3.7 for development
  • drop support for python 3.7. EOL for 3.7 is 27 Jun 2023 so only a few more months

@dependabot dependabot bot force-pushed the dependabot/pip/isort-5.12.0 branch 2 times, most recently from 363692f to c7ec1a9 Compare February 9, 2023 04:05
@dependabot dependabot bot force-pushed the dependabot/pip/isort-5.12.0 branch 2 times, most recently from 5997f1d to 87513f4 Compare February 22, 2023 04:18
@alallema
Copy link
Contributor

Thank @sanders41 for all this information I think for now we will hold back the isort version and wait for the 3.7 EOL

@dependabot dependabot bot force-pushed the dependabot/pip/isort-5.12.0 branch from 87513f4 to 32bdf6b Compare February 23, 2023 04:20
@dependabot dependabot bot force-pushed the dependabot/pip/isort-5.12.0 branch 2 times, most recently from b3e1efd to 74b24b3 Compare March 22, 2023 05:02
@dependabot dependabot bot force-pushed the dependabot/pip/isort-5.12.0 branch 2 times, most recently from 3229a0a to 96a2cd6 Compare April 3, 2023 05:10
@dependabot
Bump isort from 5.11.4 to 5.12.0
05db427 
Bumps [isort](https://github.com/pycqa/isort) from 5.11.4 to 5.12.0.
- [Release notes](https://github.com/pycqa/isort/releases)
- [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md)
- [Commits](PyCQA/isort@5.11.4...5.12.0)

---
updated-dependencies:
- dependency-name: isort
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/isort-5.12.0 branch from 96a2cd6 to 05db427 Compare April 5, 2023 05:01
@sanders41
Copy link
Collaborator

isort got updated to 5.12.0 when updating the lock file to remove Python 3.7 in #788 so this can be closed.

On main, pip freeze | grep isort = isort==5.12.0

@sanders41 sanders41 closed this Jun 28, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 28, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/isort-5.12.0 branch June 28, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alallema @sanders41