Skip to content

Fix package build #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Fix package build #704

merged 4 commits into from
Mar 13, 2023

Conversation

sanders41
Copy link
Collaborator

Pull Request

Reading through the Python docs on packaging and setuptools docs I think I have pieced together everything need to make this work with pyproject.toml now. Running python -m build locally includes all the expected files and runs without error.

Related issue

Fixes #636

What does this PR do?

  • Removes the setup.py file
  • Updates the pyproject.toml file to include everything needed for build
  • Switch from setup.py to build

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 marked this pull request as draft March 9, 2023 17:08
@sanders41 sanders41 marked this pull request as ready for review March 9, 2023 17:23
@sanders41 sanders41 added the skip-changelog The PR will not appear in the release changelogs label Mar 9, 2023
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So great! Thank you so much @sanders41 for this PR ❤️
Should we not change the CONTRIBUTING to add pipenv run python3 -m build?

@sanders41
Copy link
Collaborator Author

I don't currently see a section for this in the CONTRIBUTING do you want to add it? Do you ever do manual releases or is it always with GH Actions?

@alallema
Copy link
Contributor

I don't currently see a section for this in the CONTRIBUTING do you want to add it? Do you ever do manual releases or is it always with GH Actions?

If all goes well normally it's still github-action, so no need for you to add it in Contributing you right, I'll merge it right away.

@alallema
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 13, 2023

@bors bors bot merged commit 8aeddda into main Mar 13, 2023
@bors bors bot deleted the setup branch March 13, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

py.typed missing
2 participants