Skip to content

Remove install-pipenv-action and replace with pipx #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2023
Merged

Remove install-pipenv-action and replace with pipx #759

merged 1 commit into from
May 22, 2023

Conversation

sanders41
Copy link
Collaborator

Pull Request

Related issue

Fixes #758

What does this PR do?

  • Replaces the install-pipenv-action with pipx

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@sanders41 sanders41 added the skip-changelog The PR will not appear in the release changelogs label May 17, 2023
alallema
alallema approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanders41 for this PR!
LGTM! 😍

@alallema
Copy link
Contributor

bors merge

@alallema alallema added the maintenance Anything related to maintenance (CI, tests, refactoring...) label May 22, 2023
@meili-bors
Copy link
Contributor

meili-bors bot commented May 22, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 133d19d into main May 22, 2023
@meili-bors meili-bors bot deleted the pipenv-ci branch May 22, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alallema alallema alallema approved these changes

Assignees
No one assigned
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...) skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI throwing warnings
2 participants
@sanders41 @alallema