refacto: Inheritance refactor #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskombro
force-pushed
the
inheritance_refactor
branch
from
327130c to
d75294c
Compare
eskombro
force-pushed
the
inheritance_refactor
branch
from
d75294c to
ff355c0
Compare
eskombro
requested review from
bidoubiwa and
curquiza
and removed request for
bidoubiwa
curquiza
requested changes
May 20, 2020
Co-authored-by: Clémentine Urquizar <[email protected]>
Co-authored-by: Clémentine Urquizar <[email protected]>
bidoubiwa
reviewed
May 22, 2020
bidoubiwa
reviewed
May 22, 2020
bidoubiwa
approved these changes
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the unnecessary complexity of inheritance.
A Client handles MeiliSearch instance at a higher level (system, keys, health indexes).
An Index is a class capable of handling documents in a given index, as well as search requests and settings.
Closes #54