Skip to content

Remove huggingface setting in tests to fix flakiyness #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Remove huggingface setting in tests to fix flakiyness #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import meilisearch
from meilisearch.errors import MeilisearchApiError
from meilisearch.models.index import HuggingFaceEmbedder, OpenAiEmbedder, UserProvidedEmbedder
from meilisearch.models.index import OpenAiEmbedder, UserProvidedEmbedder
from tests import common


Expand Down Expand Up @@ -235,5 +235,4 @@ def new_embedders():
return {
"default": UserProvidedEmbedder(dimensions=1).model_dump(by_alias=True),
"open_ai": OpenAiEmbedder().model_dump(by_alias=True),
"hugging_face": HuggingFaceEmbedder().model_dump(by_alias=True),
}
5 changes: 1 addition & 4 deletions tests/settings/test_settings_embedders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# pylint: disable=redefined-outer-name
import pytest

from meilisearch.models.index import HuggingFaceEmbedder, OpenAiEmbedder, UserProvidedEmbedder
from meilisearch.models.index import OpenAiEmbedder, UserProvidedEmbedder


@pytest.mark.usefixtures("enable_vector_search")
Expand All @@ -22,7 +22,6 @@ def test_update_embedders_with_user_provided_source(new_embedders, empty_index):
assert update.status == "succeeded"
assert isinstance(response_get.embedders["default"], UserProvidedEmbedder)
assert isinstance(response_get.embedders["open_ai"], OpenAiEmbedder)
assert isinstance(response_get.embedders["hugging_face"], HuggingFaceEmbedder)


@pytest.mark.usefixtures("enable_vector_search")
Expand All @@ -38,14 +37,12 @@ def test_reset_embedders(new_embedders, empty_index):
response_get = index.get_embedders()
assert isinstance(response_get.embedders["default"], UserProvidedEmbedder)
assert isinstance(response_get.embedders["open_ai"], OpenAiEmbedder)
assert isinstance(response_get.embedders["hugging_face"], HuggingFaceEmbedder)
# Reset the setting
response_reset = index.reset_embedders()
update2 = index.wait_for_task(response_reset.task_uid)
# Get the setting after reset
assert update2.status == "succeeded"
assert isinstance(response_get.embedders["default"], UserProvidedEmbedder)
assert isinstance(response_get.embedders["open_ai"], OpenAiEmbedder)
assert isinstance(response_get.embedders["hugging_face"], HuggingFaceEmbedder)
response_last = index.get_embedders()
assert response_last is None