Skip to content

Use _geo in examples rather then geo #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

Use _geo in examples rather then geo #303

merged 1 commit into from
Jul 20, 2022

Conversation

SorenHolstHansen
Copy link
Contributor

Pull Request

What does this PR do?

Fixes #302

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@bidoubiwa
Copy link
Contributor

Hey @SorenHolstHansen thanks a lot for this fix :)

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Jul 19, 2022
@SorenHolstHansen
Copy link
Contributor Author

SorenHolstHansen commented Jul 19, 2022 •
edited
Loading

The failing tests don't seem to have anything to do with the change?

@bidoubiwa
Copy link
Contributor

@SorenHolstHansen
No ! They are failing because the SDK is not up to date with the latest Meilisearch version :)

I'm merging!

bidoubiwa
bidoubiwa approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@bidoubiwa bidoubiwa merged commit 6f98caf into meilisearch:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use "_geo" in example rather then "geo"
2 participants
@SorenHolstHansen @bidoubiwa