Rename MEILISEARCH_HOST to MEILISEARCH_URL

[washbin]

Pull Request

Related issue

Fixes #352

What does this PR do?

• rename env variables

PR checklist

Please check if your PR fulfills the following requirements:

• Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
• Have you read the contributing guidelines?
• Have you made sure that the title is accurate and descriptive of the changes?

[bidoubiwa]

Hey! Thanks a lot for your contribution 🔥 It's very well done.

[bidoubiwa]

Which linting tool are you using that fixes the styling across the code-base? Or is this something you do by hand?

[washbin]

I don't recall using anything except clippy for linting

[bidoubiwa]

Maybe I should update clippy 😂

[washbin]

which version are you on 🙈

[bidoubiwa]

Can you update the readme to fix the failing test ? sh scripts/update-readme.sh

[washbin]

Can you update the readme to fix the failing test ? sh scripts/update-readme.sh

Oh sure, let me have a look at it.

[washbin]

@bidoubiwa I am unable to reproduce the failing test in my local device, can you provide insights to why it maybe ?

[washbin]

@bidoubiwa I am unable to reproduce the failing test in my local device, can you provide insights to why it maybe ?

turns out I was looking in the wrong branch 😆 .

Ohh and we should probably include the step to update the readme in CONTRIBUTING.md or maybe just put the update script to run in CI since it's automated either way 😉

[bidoubiwa]

It is added in the contributing guide, but you need to scroll a lot to get there. Maybe it is worth adding a table of content above with all the required steps during development. What do you think?

meilisearch-rust/CONTRIBUTING.md

Lines 101 to 121 in 18c835f

	### Update the README <!-- omit in toc -->
	The README is generated. Please do not update manually the `README.md` file.
	Instead, update the `README.tpl` and `src/lib.rs` files, and run:
	```sh
	sh scripts/update-readme.sh
	```
	Then, push the changed files.
	You can check the current `README.md` is up-to-date by running:
	```sh
	sh scripts/check-readme.sh
	# To see the diff
	sh scripts/check-readme.sh --diff
	```
	If it's not, the CI will fail on your PR.

[bidoubiwa]

LGTM 🔥 Thanks a lot 🙏

[bidoubiwa]

bors merge

[washbin]

It is added in the contributing guide, but you need to scroll a lot to get there. Maybe it is worth adding a table of content above with all the required steps during development. What do you think?

meilisearch-rust/CONTRIBUTING.md

Lines 101 to 121 in 18c835f

	### Update the README <!-- omit in toc -->
	The README is generated. Please do not update manually the `README.md` file.
	Instead, update the `README.tpl` and `src/lib.rs` files, and run:
	```sh
	sh scripts/update-readme.sh
	```
	Then, push the changed files.
	You can check the current `README.md` is up-to-date by running:
	```sh
	sh scripts/check-readme.sh
	# To see the diff
	sh scripts/check-readme.sh --diff
	```
	If it's not, the CI will fail on your PR.

oh yeah, seems to be right there, totally missed it, my mistake.

Yeah, maybe adding the table of content will make it more accessible at first glance

[bors]

Build succeeded:

• clippy-check
• integration-tests
• readme-check
• rust-format
• wasm-build

[bidoubiwa]

This message is sent automatically

Thanks again for contributing to Meilisearch ❤️
If you are participating in Hacktoberfest, and you would like to receive some gift from Meilisearch too, please complete this form.