Improve the check-release tag parser to be more robust #401
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is auto-generated.
The automated script generated this PR, which updates the check-release.sh script.
Explaination
check-release.yml
used to parse theGITHUB_REF
withtr -d 'refs/tags/v'
. But,tr
deletes characters and not a specific string.Which results in a wrong parsing of tags containings the characters present in
refs/tags/v
.Example:
refs/tags/v0.1.0-strapi-v3.1
becomes0.1.0-pi-v3.1
To avoid this issue, the command is changed to a more robust parsing method:
cut -d '/' -f 3 | sed -r 's/^v//'
cut -d '/' -f 3
splits our string based on the/
and takes the 3th element.refs/tags/v0.1.0-strapi-v3.1
=>["refs", "tags", "v0.1.0-strapi-v3.1"]
sed -r 's/^v//'
removes the prependingv
.v0.1.0-strapi-v3.1
=>0.1.0-strapi-v3.1