Skip to content

Create getters for the Client #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Create getters for the Client #416

merged 1 commit into from
Feb 7, 2023

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented Feb 5, 2023

Pull Request

We currently can't extract the data contained in a client which is boring if suddenly the sdk is not suitable anymore for your use case and you just need to make one quick call yourself.

Related issue

Fixes nothing

What does this PR do?

  • create getters for the Client

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@irevoire irevoire requested a review from bidoubiwa February 5, 2023 22:36
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@bidoubiwa bidoubiwa added the enhancement New feature or request label Feb 7, 2023
@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 7, 2023

@bors bors bot merged commit a29ea75 into main Feb 7, 2023
@bors bors bot deleted the create-getter-for-client branch February 7, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants