Skip to content

Provide two methods to add documents from an async reader #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

irevoire
Copy link
Member

@irevoire irevoire commented Feb 5, 2023

Pull Request

When using Meilisearch-rust to forward documents from another source it’s a pain to use.
These two simple methods let you send raw payload to meilisearch. But you need to specify your content-type.


## Note

I didn’t implements these method for the wasm version of the crate because wasm-bindgen-futures don’t provide an AsyncReader trait.

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. For the clippy issue I think you just need to rebase with main

@bidoubiwa
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Feb 15, 2023
@bors
Copy link
Contributor

bors bot commented Feb 15, 2023

try

Build failed:

@bidoubiwa
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Feb 20, 2023
@bors
Copy link
Contributor

bors bot commented Feb 20, 2023

try

Build failed:

@bidoubiwa
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request Feb 20, 2023
@bors
Copy link
Contributor

bors bot commented Feb 20, 2023

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bidoubiwa bidoubiwa added the enhancement New feature or request label Feb 20, 2023
@bors
Copy link
Contributor

bors bot commented Feb 20, 2023

Build succeeded:

@bors bors bot merged commit 5cbad30 into main Feb 20, 2023
@bors bors bot deleted the provide-methods-to-send-raw-payloads branch February 20, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants