Skip to content

Add script to update the version of meilisearch-index-setting-macro #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

bidoubiwa
Copy link
Contributor

When publishing the package, both meilisearch and meilisearch-index-setting-macro are published.
If meilisearch-index-setting-macro has not seen its version updated, the publishing will fail as the current version on crates is the same as the one being published.

To tackle this issue without to much hassle, both the macro and meilisearch-rust are going to share the same version.

This PR creates a script to automatically update the versions and check if they are correct

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Feb 6, 2023
@bidoubiwa bidoubiwa requested a review from alallema February 6, 2023 15:41
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@bidoubiwa
Copy link
Contributor Author

bors merge

bors bot added a commit that referenced this pull request Feb 6, 2023
422: Add script to update the version of meilisearch-index-setting-macro r=bidoubiwa a=bidoubiwa

When publishing the package, both meilisearch and meilisearch-index-setting-macro are published. 
If `meilisearch-index-setting-macro` has not seen its version updated, the publishing will fail as the current version on crates is the same as the one being published.

To tackle this issue without to much hassle, both the macro and `meilisearch-rust` are going to share the same version.

This PR creates a script to automatically update the versions and check if they are correct

Co-authored-by: Charlotte Vermandel <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

Build failed:

@bidoubiwa
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request Feb 6, 2023
@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

@bors bors bot merged commit 10d0338 into main Feb 6, 2023
@bors bors bot deleted the update_version_to_v0.22.1 branch February 6, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants