Skip to content

Remove unused devdependency in macro #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

Remove unused devdependency in macro #423

merged 1 commit into from
Feb 6, 2023

Conversation

bidoubiwa
Copy link
Contributor

It is unused and causes a circular dependency issue when trying to publish

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Feb 6, 2023
@bidoubiwa bidoubiwa requested a review from irevoire February 6, 2023 16:26
irevoire
irevoire approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

Build succeeded:

@bors bors bot merged commit 2ade385 into main Feb 6, 2023
@bors bors bot deleted the remove_meilisearch_dependency_from_macro branch February 6, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irevoire irevoire irevoire approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bidoubiwa @irevoire