Skip to content

Add Debug and Clone to all public API structs, and some CS #466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 17, 2023
Merged

Add Debug and Clone to all public API structs, and some CS #466

merged 6 commits into from
May 17, 2023

Conversation

omid
Copy link
Contributor

@omid omid commented May 9, 2023 •
edited
Loading

Pull Request

What does this PR do?

  • Add Debug and Clone to all public API structs
  • some code style

@brunoocasali
Copy link
Member

Hi @omid, thanks a lot for your contribution!!

However, @bidoubiwa, the maintainer of this repo, is on holiday, so it could take some time until they get back :)

@irevoire, if you have some time, I would love to have your thoughts here!

@brunoocasali brunoocasali requested review from irevoire and bidoubiwa May 9, 2023 17:30
bidoubiwa
bidoubiwa suggested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @omid

Thanks for your contributions 🙏🙏
Some changes were not really related to the PR but are still nice to keep. Nonetheless, some others are design choices that should be discussed in an issue or another PR.

Could you remove:

  • The use of the must_use attributes everywhere
  • The use of Self instead of the structure name

bidoubiwa
bidoubiwa suggested changes May 15, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change and looks good to me ✨

@bidoubiwa
Copy link
Contributor

Tests seems to fail

@bidoubiwa bidoubiwa added the enhancement New feature or request label May 15, 2023
omid and others added 2 commits May 15, 2023 18:15
@bidoubiwa
Copy link
Contributor

There is a conflict with main due to the other PR we just merged :( Could you resolve it ? Sorry about that

@omid
Copy link
Contributor Author

omid commented May 15, 2023

There is a conflict with main due to the other PR we just merged :( Could you resolve it ? Sorry about that

np. done, with a tiny cherry on top :D

bidoubiwa
bidoubiwa approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented May 17, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit fc1d41d into meilisearch:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

@irevoire irevoire Awaiting requested review from irevoire

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omid @brunoocasali @bidoubiwa @irevoire