Add feature isahc-static-ssl #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
reviewed
May 15, 2023
Cargo.toml
Outdated
| @@ -38,8 +38,9 @@ wasm-bindgen = "0.2" | |||
| wasm-bindgen-futures = "0.4" | |||
|
|
|||
| [features] | |||
| default = ["isahc-static-curl"] | |||
| default = ["isahc-static-curl", "isahc-static-ssl"] | |||
There was a problem hiding this comment.
What would be the point of using both by default?
Suggested change
| default = ["isahc-static-curl", "isahc-static-ssl"] | |
| default = ["isahc-static-curl"] |
There was a problem hiding this comment.
Guessed you aim for a more static-friendly lib. Anyways, fixed.
bidoubiwa
added
skip-changelog
TcOhamtyw6lt
force-pushed
the
expose_isahc_static_ssl-fix_taskinfo_doc_test
branch
from
05eaa3a to
23950e9
Compare
With isahc-static-curl feature compiling a static build was still not achievable since it still needed system-wide installed OpenSSL libraries. With the isahc-static-ssl feature was added, now its possible to compile the library without OpenSSL libraries installed. The src/task_info.rs file had a failing doc test due not using environmental variables like other tests do. This issue was fixed.
TcOhamtyw6lt
force-pushed
the
expose_isahc_static_ssl-fix_taskinfo_doc_test
branch
from
23950e9 to
10a6354
Compare
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #468
What does this PR do?
With isahc-static-curl feature compiling a static build was still not achievable since it still needed system-wide installed OpenSSL libraries. With the isahc-static-ssl feature was added, now its possible to compile the library without OpenSSL libraries installed.
The src/task_info.rs file had a failing doc test due not using environmental variables like other tests do. This issue was fixed.
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!