Skip to content

refactor: use iterator instead for-loop #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2023
Merged

refactor: use iterator instead for-loop #470

merged 1 commit into from
May 15, 2023

Conversation

bestgopher
Copy link
Contributor

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • ...

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

irevoire
irevoire previously approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@irevoire irevoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@bidoubiwa
Copy link
Contributor

@bestgopher thanks for this 🙏🙏🙏

Could you format your code ?

@bestgopher
Copy link
Contributor Author

Done!

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label May 15, 2023
bidoubiwa
bidoubiwa approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented May 15, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 029e2db into meilisearch:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

@irevoire irevoire irevoire left review comments

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bestgopher @bidoubiwa @irevoire