Skip to content

Fix json serialization error if meilisearch response contains facet_stats #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 31, 2023
Merged

Fix json serialization error if meilisearch response contains facet_stats #478

merged 3 commits into from
May 31, 2023

Conversation

Vedmak
Copy link

@Vedmak Vedmak commented May 30, 2023

Pull Request

Related issue

Fixes #474

What does this PR do?

  • change field types of FacetStats struct from u32 to f64
  • add test for facet_stats

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

bidoubiwa
bidoubiwa reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution 🙏

@bidoubiwa bidoubiwa added the bug Something isn't working label May 31, 2023
@bidoubiwa
Copy link
Contributor

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented May 31, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 00acb01 into meilisearch:main May 31, 2023
@Vedmak Vedmak deleted the facet-stats-fix branch May 31, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanders41 sanders41 sanders41 left review comments

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error parsing response JSON for facetStats
3 participants
@Vedmak @bidoubiwa @sanders41