Skip to content

Add support for typo tolerance customization #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 12, 2023
Merged

Add support for typo tolerance customization #480

merged 20 commits into from
Jun 12, 2023

Conversation

omid
Copy link
Contributor

@omid omid commented Jun 6, 2023 •
edited
Loading

It's coming after #351 PR.
I fixed the comments of the other PR here.

fixes #260

@omid omid changed the title Typotolerance Add support for typo tolerance customization Jun 6, 2023
@bidoubiwa
Copy link
Contributor

Hey @omid ! Thanks a lot for your contribution 🙏 I'll be reviewing it tomorrow

bidoubiwa
bidoubiwa reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing PR ✨ Very clean :)

Thanks so much, I couldn't find any issue here.

@omid @bidoubiwa
Update src/settings.rs
51f52dc 
Co-authored-by: cvermand <[email protected]>
bidoubiwa
bidoubiwa approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨

@bidoubiwa
Copy link
Contributor

bors merge

@bidoubiwa bidoubiwa added the enhancement New feature or request label Jun 12, 2023
@meili-bors
Copy link
Contributor

meili-bors bot commented Jun 12, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 6cf84f5 into meilisearch:main Jun 12, 2023
@meili-bot
Copy link
Contributor

This message is sent automatically

Thank you very much for submitting your PR! Did you know that throughout the month of June we’re holding a rafle?
If you share the link to your merged PR in our #giveaway Discord channel, you’ll automatically join a lottery for a chance at winning some Meiliswag. 🙂
Don’t hesitate to join us: https://discord.com/channels/1006923006964154428/1111273670657200198

@omid omid deleted the typotolerance branch June 12, 2023 10:38
@omid omid mentioned this pull request Jun 12, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support to the typo tolerance customization
4 participants
@omid @bidoubiwa @meili-bot @vishalsodani