Add code samples and remove useless ones #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curquiza
added
the
skip-changelog
bidoubiwa
approved these changes
Sep 25, 2023
|
bors merge |
meili-bors bot
added a commit
that referenced
this pull request
Sep 25, 2023
523: Add code samples and remove useless ones r=curquiza a=curquiza I created [scripts to manage code samples](https://github.com/meilisearch/integration-automations/pull/164) (internal only) 1. I found out the following code samples are still in this repo but not used by the documentation anymore, so I removed them: ```bash meilisearch-rust - 'settings_guide_filterable_attributes_1' not found in documentation - 'settings_guide_typo_tolerance_1' not found in documentation - 'documents_guide_add_movie_1' not found in documentation - 'getting_started_communicating_with_a_protected_instance' not found in documentation - 'faceted_search_facets_1' not found in documentation - 'faceted_search_2' not found in documentation ``` 2. I found the following code samples were missing: ```bash meilisearch-rust - 'search_parameter_guide_facet_stats_1' not found - 'facet_search_1' not found - 'facet_search_2' not found - 'facet_search_3' not found ``` However, only `search_parameter_guide_facet_stats_1`was added because of missing feature implementation for the others Co-authored-by: curquiza <[email protected]>
|
Timed out. |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created scripts to manage code samples (internal only)
However, only
search_parameter_guide_facet_stats_1was added because of missing feature implementation for the others