Skip to content

Add pre-release tests in github action #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 2, 2021
Merged

Add pre-release tests in github action #103

merged 5 commits into from
Aug 2, 2021

Conversation

alallema
Copy link
Contributor

No description provided.

@alallema alallema requested a review from curquiza July 22, 2021 14:08
@alallema alallema added the skip-changelog The PR will not appear in the release changelogs label Jul 26, 2021
curquiza
curquiza requested changes Aug 2, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the curl check in both yml file? :)

curquiza
curquiza approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!! :)

bors merge

bors bot added a commit that referenced this pull request Aug 2, 2021
@bors @alallema
Merge #103
9a363a9 
103: Add pre-release tests in github action r=curquiza a=alallema



Co-authored-by: alallema <[email protected]>
@alallema
Copy link
Contributor Author

alallema commented Aug 2, 2021 •
edited
Loading

@curquiza
Also the code fails due to memory allocation in the config that I fixed it on the PR of the release #101 do I put it here too?

@alallema
Copy link
Contributor Author

alallema commented Aug 2, 2021

Opps too late you are fast

@curquiza
Copy link
Member

curquiza commented Aug 2, 2021

Because #101 was merged into bump-meilisearch-v0.21.0 and not into main, pretty sure bors will not merge it.

@bors
Copy link
Contributor

bors bot commented Aug 2, 2021

Timed out.

@alallema alallema requested a review from curquiza August 2, 2021 14:44
curquiza
curquiza approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 2, 2021

Build succeeded:

@bors bors bot merged commit 389f6ea into main Aug 2, 2021
@bors bors bot deleted the pre-release-workflow branch August 2, 2021 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alallema @curquiza