Skip to content

Fix collecting index names when indices not provided #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

norkunas
Copy link
Collaborator

Currently when trying to run bin/console meili:clear it returns:

Cannot clear index. Not found.
Done!

@norkunas norkunas force-pushed the fix branch 6 times, most recently from 304879c to 7491640 Compare August 25, 2021 08:00
@curquiza
Copy link
Member

curquiza commented Aug 26, 2021

Hello @norkunas! Thanks a lot for your PR, contributions are really appreciated. Can you describe what you succeeded to fix exactly? Did you want to make the message clearer?

@norkunas
Copy link
Collaborator Author

norkunas commented Aug 26, 2021

Currently we need to configure indices in config/packages/meili_search.yaml so I expect import/clear command to automatically take these indices to import or clear when I don't provide via --indices option.

The test shows what I expect :)

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a good additon! thanks

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 26, 2021

@bors bors bot merged commit 8655bbd into meilisearch:main Aug 26, 2021
@norkunas norkunas deleted the fix branch August 26, 2021 11:40
@norkunas
Copy link
Collaborator Author

Thanks for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants