Skip to content

Normalize entity id before index or remove #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2021
Merged

Normalize entity id before index or remove #110

merged 1 commit into from
Sep 1, 2021

Conversation

tomdoo
Copy link
Contributor

@tomdoo tomdoo commented Aug 27, 2021

Fixes this issue : #109

@curquiza
Copy link
Member

Hello @tomdoo

Thanks for this PR

  • Can you add tests please? :)
  • Can you fix the code style CI? It seems your PR introduces an error for this check

@dotfesse
Normalize entity id before index or remove
3a9033e 
Normalize entity id before index or remove


Normalize entity id before index or remove
@curquiza curquiza linked an issue Sep 1, 2021 that may be closed by this pull request
Cannot update or delete documents with an Uuid #109
Closed
@curquiza
Copy link
Member

curquiza commented Sep 1, 2021

bors try

bors bot added a commit that referenced this pull request Sep 1, 2021
@bors
Try #110:
4971a07
@bors
Copy link
Contributor

bors bot commented Sep 1, 2021

try

Build succeeded:

curquiza
curquiza approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! and the tests!

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 1, 2021

Build succeeded:

@bors bors bot merged commit 0a8bbda into meilisearch:main Sep 1, 2021
@tomdoo tomdoo deleted the bugfix/issue-109-normalize-ids branch September 1, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot update or delete documents with an Uuid
3 participants
@tomdoo @curquiza @dotfesse