Skip to content

Add option to meili:import command to override batch size #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2021
Merged

Add option to meili:import command to override batch size #124

merged 1 commit into from
Nov 9, 2021

Conversation

norkunas
Copy link
Collaborator

@norkunas norkunas commented Nov 9, 2021

Pull Request

What does this PR do?

Allows to optionally provide --batch-size option to meili:import to use different batch size for some indices than configured in bundle config.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

curquiza
curquiza approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this addition @norkunas :)

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 9, 2021

Build succeeded:

@bors bors bot merged commit e9b8590 into meilisearch:main Nov 9, 2021
@norkunas norkunas deleted the custom-batch-size branch November 9, 2021 12:52
@curquiza curquiza added the enhancement New feature or request label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@norkunas @curquiza