Skip to content

Add option to meili:import command to override default timeout #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 21, 2021
Merged

Add option to meili:import command to override default timeout #132

merged 1 commit into from
Dec 21, 2021

Conversation

revenkroz
Copy link
Contributor

Pull Request

What does this PR do?

Fixes #131

PR checklist

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@alallema
Copy link
Contributor

Hi @revenkroz,
Thank you so much for contributing to Meilisearch ❤️!
@curquiza is on holiday and will review your PR once they are back.

curquiza
curquiza previously approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @revenkroz for this PR :)

Sorry for the delay

bors merge

bors bot added a commit that referenced this pull request Dec 17, 2021
@bors
Merge #132
1212bd7 
132: Add option to meili:import command to override default timeout r=curquiza a=revenkroz

# Pull Request

## What does this PR do?
Fixes #131

## PR checklist
- [x] Does this PR fix an existing issue?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?


Co-authored-by: Oleg Koval <[email protected]>
@bors
Copy link
Contributor

bors bot commented Dec 17, 2021

Build failed:

@curquiza
Copy link
Member

Oops looks like there is an issue with the tests, can you fix?

Also, I notice you did not add your email address (associated with your GitHub account) in your commit. It means you will not be added to our contributor list when this PR will be merged, which is too bad since you are really involved in this repo!

@curquiza
Copy link
Member

curquiza commented Dec 17, 2021 •
edited
Loading

Only the Code style failure comes from your PR, not the one regarding PHP 8.0. We have to fix integration-tests (PHP 8.0) in another PR

@revenkroz revenkroz force-pushed the response-timeout-option branch from ae0da51 to 88aacff Compare December 17, 2021 15:15
@revenkroz
Copy link
Contributor Author

@curquiza thanks for review. I added an email and fixed the code style.

@curquiza
Copy link
Member

bors try

bors bot added a commit that referenced this pull request Dec 20, 2021
@bors
Try #132:
1543919
@bors
Copy link
Contributor

bors bot commented Dec 20, 2021

try

Build succeeded:

curquiza
curquiza approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before I merge, @revenkroz, can you give an example of how using your addition, so that I can document it? :)

@curquiza curquiza added the enhancement New feature or request label Dec 20, 2021
@revenkroz
Copy link
Contributor Author

@curquiza
bin/console meili:import --response-timeout=<timeout in ms>

For example:
bin/console meili:import --response-timeout=10000 for 10 seconds as timeout

@curquiza
Copy link
Member

Thank you so much @revenkroz!

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 21, 2021

Build succeeded:

@bors bors bot merged commit 2f146e0 into meilisearch:main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to set request timeout
3 participants
@revenkroz @alallema @curquiza