Skip to content

Fix exception filename #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2022
Merged

Fix exception filename #160

merged 1 commit into from
Feb 8, 2022

Conversation

norkunas
Copy link
Collaborator

@norkunas norkunas commented Feb 7, 2022

Pull Request

What does this PR do?

Fixes this warning:

Generating optimized autoload files
Class MeiliSearch\Bundle\Exception\TaskException located in ./vendor/meilisearch/search-bundle/src/Exception/UpdateException.php does not comply with psr-4 autoloading standard. Skipping.

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@curquiza curquiza requested a review from brunoocasali February 8, 2022 18:12
@curquiza
Copy link
Member

curquiza commented Feb 8, 2022 •
edited
Loading

Hello @norkunas

Thanks for your both PRs ❤️

I'll let @brunoocasali, the new maintainer of this repository, merge them. I'm still working for Meili so I will still be around 👋 Thanks again for your help!

brunoocasali
brunoocasali approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Thanks a lot for this @norkunas

@brunoocasali
Copy link
Member

bors merge

@brunoocasali brunoocasali added the enhancement New feature or request label Feb 8, 2022
@bors
Copy link
Contributor

bors bot commented Feb 8, 2022

Build succeeded:

@bors bors bot merged commit 988b983 into meilisearch:main Feb 8, 2022
@norkunas norkunas deleted the fix branch February 8, 2022 18:43
@brunoocasali brunoocasali mentioned this pull request Feb 8, 2022
Merged
bors bot added a commit that referenced this pull request Feb 9, 2022
@bors @brunoocasali
Merge #162
dce22c5 
162: Update meilisearch-symfony for the next release (v0.7.1) r=brunoocasali a=brunoocasali

Changes:
- #160
- #161

Co-authored-by: Bruno Casali <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norkunas @curquiza @brunoocasali