Add landing_getting_started_1 code samples #180
Conversation
| @@ -0,0 +1,38 @@ | |||
| landing_getting_started_1: |- | |||
| # Configure your entities by adding them in config/packages/meili_search.yaml | |||
There was a problem hiding this comment.
Since this file has two different languages, I must use markdown here, or the landing page will understand it?
CC: @bidoubiwa @mdubus
There was a problem hiding this comment.
Hey! It will not unfortunately :/ We have the same issue in angular. We settled for this with morgane: https://github.com/meilisearch/meilisearch-angular/blob/main/.code-samples.meilisearch.yaml
We are not sure how ugly it will look, when we now more we can potentially try things out.
| #[Route('/add-movies', name: 'addMovies')] | ||
| public function addMovies(ManagerRegistry $doctrine): Response | ||
| { | ||
| $entityManager = $doctrine->getManager(); |
There was a problem hiding this comment.
I'm not sure to understand, for me you already said it will be automatically updated some line below right?
// Inserting data in your DB table will automatically update your Meilisearch index
There was a problem hiding this comment.
Yeah, but do you think the comment // Inserting data in your DB table will automatically update your Meilisearch index is necessary?
There was a problem hiding this comment.
I don't see any problem to have it on a sample code to remind this information. Will the content of this comment be mentioned before or after the sample code?
If not, it seems useful to me because there is a bit of magic with the ORM hooks here, it also helps someone who doesn't necessarily read the surrounding text and copy and paste the sample code directly.
There was a problem hiding this comment.
It's ok from my POV to let it. We added it to Rails as well, and I agree with guillaume: it's a little bit magic and not obvious, from my POV
brunoocasali
force-pushed
the
code-samples-update
branch
from
678bac5 to
9639c43
Compare
|
bors merge |
Add a
landing_getting_started_1code sample to be on the new landing page block.Closes: #174