Fixed ClassMetadata usage in SearchableEntity (fixes #158) #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@althaus thanks a lot for your contribution!! I read your comment here #158 (comment), but I would like to understand why this was "working" before... |
|
Haven't dug deeper, but I'd guess that those are the "same" classes at the end or some interop code resolves this. |
brunoocasali
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
LGTM! 🌮
Thanks a lot @althaus for contributing with Meilisearch 👨🎤 🤘
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jul 12, 2022
192: Update version for the next release (v0.8.0) r=brunoocasali a=brunoocasali This version makes this package compatible with Meilisearch v0.28.0 🎉 Check out the changelog of [Meilisearch v0.28.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.28.0) for more information on the changes. ## 💥 Breaking changes - This release is **only** compatible with the latest version of [Meilisearch v0.28.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.28.0) ## 🚀 Enhancements * Support Symfony 6.1 (#181) `@norkunas` * Improve Docker configuration in the package (#182) `@brunoocasali` * Fixed `ClassMetadata` usage in `SearchableEntity`. (#185) `@althaus` ## 🐛 Bug Fixes * Fix meili:create when the configuration has no settings (#189) `@brunoocasali` Thanks again to `@althaus,` `@brunoocasali,` and `@norkunas!` 🎉 Co-authored-by: Bruno Casali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Fixes #158
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!