Drop illuminate/collections #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
norkunas
force-pushed
the
drop-illuminate
branch
from
5741946 to
c225cb7
Compare
norkunas
force-pushed
the
drop-illuminate
branch
from
c225cb7 to
f1d22fd
Compare
|
OMG that's amazing @norkunas 🎉 I'll review it soon! |
brunoocasali
approved these changes
Oct 27, 2022
|
This message is sent automatically Thanks again for contributing to Meilisearch ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #184
What does this PR do?
I've extracted all necessary methods to a custom Collection class not to break any test.
At least the dropped dependency now won't block other dependencies to update in apps.
PR checklist
Please check if your PR fulfills the following requirements: