Removing document issue, send documentId instead of array #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emulienfou
added
bug
|
Hey @emulienfou |
|
Hello @emulienfou, I agree with @bidoubiwa, adding some tests would be awesome 🙂 |
…etup (#16) * Update CONTRIBUTING.md * Update CONTRIBUTING.md
* Fix clear command, checking return status code * Fixing import related to meilisearch-php ^0.12 Co-authored-by: david <[email protected]>
) Co-authored-by: david <[email protected]>
Update meilisearch/meilisearch-php requirement from ^0.12 to ^0.13
* Update Engine.php * Fix linter * Update src/Engine.php Co-authored-by: Arkadius Stefanski <[email protected]> Co-authored-by: Arkadius Stefanski <[email protected]>
This reverts commit 337724b
curquiza
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to remove a document from MeiliSearch indices, code sent to
deleteDocument()method was:Since the
\MeiliSearch\Endpoints\Delegates\HandlesDocuments::deleteDocumentneed a$documentIdof type int/string this was returning an error.This PR fix this behavior