Skip to content

Fix normalization with NormalizableInterface #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2023
Merged

Fix normalization with NormalizableInterface #231

merged 1 commit into from
Mar 14, 2023

Conversation

norkunas
Copy link
Collaborator

Pull Request

Related issue

Fixes #228

What does this PR do?

  • Starts taking into account Symfony\Component\Serializer\Normalizer\NormalizableInterface when indexing documents

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

@norkunas norkunas force-pushed the fix-normalization branch from ea60c0e to 5dd36ae Compare March 10, 2023 09:07
@norkunas norkunas force-pushed the fix-normalization branch from 5dd36ae to 92295f4 Compare March 10, 2023 09:26
@brunoocasali brunoocasali added the enhancement New feature or request label Mar 14, 2023
brunoocasali
brunoocasali approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it locally, works perfectly @norkunas 🎉 !

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 14, 2023

Build succeeded:

@bors bors bot merged commit 65486e6 into meilisearch:main Mar 14, 2023
@norkunas norkunas deleted the fix-normalization branch March 14, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunoocasali brunoocasali brunoocasali approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use of NormalizableInterface does not seem to work
2 participants
@norkunas @brunoocasali