Allow to use services for settings

[norkunas]

Pull Request

Related issue

Fixes #248

What does this PR do?

• Allows services to be used in index settings configuration and consumed on index create/import.

PR checklist

Please check if your PR fulfills the following requirements:

• Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
• Have you read the contributing guidelines?
• Have you made sure that the title is accurate and descriptive of the changes?

Opened a a POC so we can discuss if this is the way to go :)

Things to notice:

• We should probably split CommandsTest someday into multiple test files and use different config files, as now when you add a separate config for test most of tests output must also be updated.
• Not validating the configuration schema properly is error prone. Had some hard times when just got Meilisearch\Exceptions\ApiException: Json deserialize error: invalid type: map, expected a sequence at line 1 column 0 and how should I know which config setting is related? So imho we should properly validate all the settings for a better DX.

[brunoocasali]

Not validating the configuration schema properly is error prone. Had some hard times when just got Meilisearch\Exceptions\ApiException: Json deserialize error: invalid type: map, expected a sequence at line 1 column 0 and how should I know which config setting is related? So imho we should properly validate all the settings for a better DX.

Can you generate an issue based on this comment @norkunas?

[brunoocasali]

Hi @norkunas, sorry for the massive delay in reviewing your PR.

I'm suggesting a change to include an interface instead of using the invocation directly. I think it would be more idiomatic + easier to detect errors and evolve the code.

[brunoocasali]

Is there any requirement to have the Interface suffix?

SettingsProviderInterface

[norkunas]

SearchService is also an interface, so avoided

[brunoocasali]

Like this: https://www.php-fig.org/bylaws/psr-naming-conventions/

[brunoocasali]

I think we could have the Interface suffix on both. But it could be done later I'll create a new issue to make this repo PSR complaint https://www.php-fig.org/psr/

[brunoocasali]

bors merge

[meili-bors]

Build succeeded:

• Code style
• integration-tests (PHP 7.4) (Symfony 5.4.*)
• integration-tests (PHP 8.0) (Symfony 6.0.*)
• integration-tests (PHP 8.1) (Symfony 6.1.*)
• integration-tests (PHP 8.2) (Symfony 6.2.*)

[meili-bot]

This message is sent automatically

Thank you very much for submitting your PR! Did you know that throughout the month of June we’re holding a rafle?
If you share the link to your merged PR in our #giveaway Discord channel, you’ll automatically join a lottery for a chance at winning some Meiliswag. 🙂
Don’t hesitate to join us: https://discord.com/channels/1006923006964154428/1111273670657200198