Skip to content

Require explicitly the PHP v8 polyfill #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2023
Merged

Require explicitly the PHP v8 polyfill #267

merged 1 commit into from
Jul 13, 2023

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Jun 25, 2023

Pull Request

as the class MeilisearchExtension calls str_starts_with (doc)
This polyfill must be required explicitly imho (not via transient deps)

obviously feel free to close, spotted while checking codebases related to this issue #263

@norkunas
Copy link
Collaborator

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jul 13, 2023

Build succeeded:

@meili-bors meili-bors bot merged commit 488b1cd into meilisearch:main Jul 13, 2023
@94noni 94noni deleted the php-8-polyfill branch July 13, 2023 07:29
@brunoocasali brunoocasali added the enhancement New feature or request label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@norkunas norkunas norkunas approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@94noni @norkunas @brunoocasali