Skip to content

chore: add testruns for PHP 8.3 #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2023
Merged

chore: add testruns for PHP 8.3 #293

merged 1 commit into from
Sep 20, 2023

Conversation

Chris53897
Copy link
Contributor

What does this PR do?

  • Add testrun for PHP 8.3 with symfony 6.3
  • bump github actions/checkout v3 => v4

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Chris53897 for this PR!

Can you update the bors.toml file?

@curquiza curquiza added skip-changelog The PR will not appear in the release changelogs maintenance Anything related to maintenance (CI, tests, refactoring...) labels Sep 18, 2023
bump github actions/checkout v3 => v4
@Chris53897
Copy link
Contributor Author

@curquiza Of course

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors merge

@curquiza
Copy link
Member

bors merge-

@curquiza
Copy link
Member

bors merge

@curquiza
Copy link
Member

Merging by hand, looks like we have an issue with bors. The tests pass, so everything is good

Capture d’écran 2023-09-20 à 13 28 21

@curquiza curquiza merged commit 5e464b0 into meilisearch:main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Anything related to maintenance (CI, tests, refactoring...) skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants