Skip to content

Rename indexName to indexUid #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2021
Merged

Rename indexName to indexUid #69

merged 1 commit into from
Apr 27, 2021

Conversation

codedge
Copy link
Contributor

@codedge codedge commented Apr 24, 2021 •
edited
Loading

This PR renames the indexName variables to indexUid, see #58.

curquiza
curquiza approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @codedge! Thanks for this PR 😄
bors merge

@curquiza curquiza added the skip-changelog The PR will not appear in the release changelogs label Apr 27, 2021
@bors
Copy link
Contributor

bors bot commented Apr 27, 2021

Build succeeded:

@bors bors bot merged commit 1cad58f into meilisearch:main Apr 27, 2021
@curquiza curquiza mentioned this pull request Apr 27, 2021
Open
3 tasks
@blump blump mentioned this pull request Jun 9, 2021
Merged
bors bot added a commit that referenced this pull request Jun 21, 2021
@bors @curquiza
Merge #89
6f58dac 
89: Refacto rename indexName to indexUid r=curquiza a=blump

this PR corrects the minor omnission of PR #69 

Co-authored-by: Julien Colinet <[email protected]>
Co-authored-by: Clémentine Urquizar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codedge @curquiza