Skip to content

Fix mobile in dark mode #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2021
Merged

Fix mobile in dark mode #171

merged 1 commit into from
Jul 12, 2021

Conversation

mdubus
Copy link
Member

@mdubus mdubus commented Jul 7, 2021

What's wrong ?

Dark mode in mobile is broken

What's inside this PR ?

A color change on the correct class in mobile, with an !important to override the light mode's !important 🙄

Screenshots

Before:
before

After:
after

@mdubus mdubus added the bug Something isn't working label Jul 7, 2021
@mdubus mdubus requested a review from bidoubiwa July 7, 2021 14:37
@bidoubiwa
Copy link
Contributor

Mobile searchbar is a bit broken but I think the problem may be related to docs-searchbar.js and not this plugin
Screenshot 2021-07-07 at 17 45 50
Screenshot 2021-07-07 at 17 44 57

compared to algolia:

Screenshot 2021-07-07 at 17 46 35

@mdubus
Copy link
Member Author

mdubus commented Jul 8, 2021 •
edited
Loading

Mobile searchbar is a bit broken but I think the problem may be related to docs-searchbar.js and not this plugin

Actually that's because of the layout "columns" by default, which is not a good idea in mobile.
If you change the layout to "simple", it's much more better :)
But yes, people shouldn't have to choose the "simple" layout because the columns one seems broken in mobile, I totally agree !

Capture d’écran 2021-07-08 à 08 29 23

Capture d’écran 2021-07-08 à 08 29 36

bidoubiwa
bidoubiwa approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution to that would be to create a listener on window size changes and re-render the searchbar with this parameter. Nonetheless, this is out of our scope as it should be done and decided by the user.

@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Jul 12, 2021

Build succeeded:

@bors bors bot merged commit 0b346ed into main Jul 12, 2021
@bors bors bot deleted the fix_colors_dark_mode_mobile branch July 12, 2021 09:10
@bidoubiwa bidoubiwa added skip-changelog The PR will not appear in the release changelogs and removed skip-changelog The PR will not appear in the release changelogs labels Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bidoubiwa bidoubiwa bidoubiwa approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdubus @bidoubiwa