Skip to content

Change playground cmd in contributing #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2021
Merged

Change playground cmd in contributing #198

merged 3 commits into from
Nov 25, 2021

Conversation

bidoubiwa
Copy link
Contributor

No description provided.

@bidoubiwa bidoubiwa requested a review from mdubus November 24, 2021 17:06
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Nov 24, 2021
mdubus
mdubus reviewed Nov 25, 2021
View reviewed changes
Copy link
Member

@mdubus mdubus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see the command serve in the package.json, and no playground command 🧐

@mdubus mdubus self-requested a review November 25, 2021 08:47
mdubus
mdubus requested changes Nov 25, 2021
View reviewed changes
Copy link
Member

@mdubus mdubus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I get it. This is related to #193
There's still the command yarn serve inside the Readme, you should edit it 😉

@bidoubiwa
Copy link
Contributor Author

my bad ! I mixed things up

@bidoubiwa bidoubiwa requested a review from mdubus November 25, 2021 14:43
@bidoubiwa
Copy link
Contributor Author

bors merge

@bors
Copy link
Contributor

bors bot commented Nov 25, 2021

Build succeeded:

@bors bors bot merged commit d87af7b into main Nov 25, 2021
@bors bors bot deleted the change_wrong_cmd branch November 25, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdubus mdubus mdubus approved these changes

Assignees
No one assigned
Labels
skip-changelog The PR will not appear in the release changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bidoubiwa @mdubus